Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client breaking change #29

Closed
wimski opened this issue Aug 25, 2021 · 2 comments
Closed

Client breaking change #29

wimski opened this issue Aug 25, 2021 · 2 comments

Comments

@wimski
Copy link

wimski commented Aug 25, 2021

php-http/mock-client introduced a breaking change in a minor release. This breaks Swis\Http\Fixture\Client::doSendRequest because the parent method no longer exists.

https://github.com/php-http/mock-client/blame/a797c2a9122cccafcce14773b8a24d2808a9ab44/src/Client.php#L87

Adding this new method would fix it:

/**
 * {@inheritdoc}
 */
public function sendRequest(RequestInterface $request): ResponseInterface
{
    $this->setDefaultResponse($this->fixtureResponseBuilder->build($request));

    return parent::sendRequest($request);
}
@JaZo JaZo closed this as completed in 543b47a Aug 30, 2021
@JaZo
Copy link
Member

JaZo commented Aug 30, 2021

Fixed in 2.3.1!

@JaZo
Copy link
Member

JaZo commented Aug 30, 2021

Sorry, 2.3.1 is a bad release, please use 2.3.2 instead! Monday mornings...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants