Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking additional properties to the respective mortgage #170

Closed
celinevananraad opened this issue Jan 18, 2024 · 1 comment · Fixed by #177
Closed

Linking additional properties to the respective mortgage #170

celinevananraad opened this issue Jan 18, 2024 · 1 comment · Fixed by #177
Assignees

Comments

@celinevananraad
Copy link
Collaborator

celinevananraad commented Jan 18, 2024

It concerns additional properties and the respective mortgages with a third party.
Currently, it is not possible to identify which mortgage is linked to which additional property, as they are stored under different levels.
The respective mortgage is stored under ApplicantDetail - financialSituation - liabilities and the additional property is stored under ApplicantDetail - financialSituation - additionalProperties
This is especially a problem if there are more than one additional property.
Therefor,e I would like to discuss possible solutions:
• implement an unique identifier to identify which mortgage is linked to the additional property
• remove the enum ‘mortgage’ from the Liability move it down to the additional property section
• keep the existing mortgage under liabilities and add an additional field under additionalProperties such as i.e. mortgageAmountAdditionalProperty

From our side (TKB) we would prefer the last solution.

@celinevananraad celinevananraad changed the title linking additional properties to the respective mortgage Linking additional properties to the respective mortgage Jan 18, 2024
@celinevananraad celinevananraad self-assigned this Jan 18, 2024
@NikolajMarwitz
Copy link

Celine will create a pull request with a possible solution, we will discuss the proposal in the next working stream meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants