Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service document should support advertising min and max segment sizes #34

Open
alexdutton opened this issue Apr 2, 2020 · 2 comments
Open
Assignees
Labels
enhancement New feature or request review

Comments

@alexdutton
Copy link
Contributor

Invenio has min and max part size limits, which will also apply to the invenio-sword segmented upload deposit implementation.

At the moment, invenio-sword will reject segment-init requests outside of these limits with a ValidationError, but it has no standardised way to advertise the requirements for clients to follow.

Can we add optional minSegmentSize and maxSegmentSize attributes to the service document?

@alexdutton alexdutton added the enhancement New feature or request label Apr 2, 2020
@alexdutton alexdutton assigned alexdutton and unassigned alexdutton Apr 2, 2020
@richard-jones
Copy link
Contributor

richard-jones commented Jun 12, 2020

Notes on implementation:

  • add to the example json document

  • add to the json schema

  • Add a error types for exceeding/not meeting these requirements

  • Update description of usage in 16.4

  • Update description of errors in 16.9

@alexdutton
Copy link
Contributor Author

alexdutton commented Jul 14, 2020

Have these changes been published to GitHub Pages? I can't see any new properties at https://swordapp.github.io/swordv3/service-document.schema.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review
Projects
None yet
Development

No branches or pull requests

2 participants