Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to PlotTrajectories #6131

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Jun 27, 2024

Proposed changes

  • Plot a marker at the current position of the black holes.

Also some improvements to help with calling the plotting functions from outside the CLI:

  • Downsample data outside of the plotting function. Don't downsample by default.
  • Allow to pass in a figure object in which to plot.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

- Plot a marker at the current position of the black holes.

Also some improvements to help with calling the plotting
functions from outside the CLI:

- Downsample data outside of the plotting function. Don't
  downsample by default.
- Allow to pass in a figure object in which to plot.
@nilsvu nilsvu requested a review from knelli2 June 27, 2024 20:53
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Jun 27, 2024
@knelli2 knelli2 merged commit 598a9a0 into sxs-collaboration:develop Jun 28, 2024
22 checks passed
@nilsvu nilsvu deleted the plot_trajectories branch June 28, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants