Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain initial data resolution in control loop. #6162

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

iago-mendes
Copy link
Member

Proposed changes

This PR ensures that the control loop uses the resolution specified in the first initial data run. Before, it was incorrectly using the default resolution (L=1, P=6).

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 requested a review from nilsvu July 19, 2024 00:04
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh looks like you need to update the tests as well

@knelli2 knelli2 enabled auto-merge July 19, 2024 02:25
@knelli2 knelli2 added the auto-merge GitHub's auto-merge has been enabled for this PR. label Jul 19, 2024
@knelli2 knelli2 merged commit d405764 into sxs-collaboration:develop Jul 19, 2024
22 checks passed
@knelli2 knelli2 added the cli/pybindings Command line interface & Python bindings label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge GitHub's auto-merge has been enabled for this PR. cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants