fix: build jemalloc with 64KB pagesize for linux/arm64 (#1270)

sxyazi · Jul 7, 2024 · 9d0ef9a · 9d0ef9a
1 parent 11547ee
commit 9d0ef9a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 13 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml
@@ -13,6 +13,8 @@ body:
         - macOS
         - Windows
         - Windows WSL
+        - FreeBSD X11
+        - FreeBSD Wayland
     validations:
       required: true
   - type: input
@@ -22,31 +24,32 @@ body:
       placeholder: "ex: kitty v0.32.2"
     validations:
       required: true
-  - type: dropdown
-    id: tried_main
-    attributes:
-      label: Did you try the latest code to see if this problem got fixed?
-      options:
-        - Tried, but the problem still
-        - Not tried, and I'll explain why below
-    validations:
-      required: true
   - type: textarea
     id: debug
     attributes:
       label: "`yazi --debug` output"
-      description: Please do a `yazi --debug` and paste the output here.
+      description: Please run `yazi --debug` and paste the debug information here.
       value: |
         <details>
 
-        <!-- Paste the output between the backticks below: -->
         ```sh
+        ##### ↓↓↓ Paste the output here: ↓↓↓ #####
+
 
         ```
 
         </details>
     validations:
       required: true
+  - type: dropdown
+    id: tried_main
+    attributes:
+      label: Did you try the latest nightly build to see if the problem got fixed?
+      options:
+        - Yes, and I updated the debug information above (`yazi --debug`) to the nightly that I tried
+        - No, and I'll explain why below
+    validations:
+      required: true
   - type: textarea
     id: description
     attributes:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -24,7 +24,10 @@ jobs:
 
       - name: Install gcc-aarch64-linux-gnu
         if: matrix.target == 'aarch64-unknown-linux-gnu'
-        run: sudo apt-get update && sudo apt-get install -yq gcc-aarch64-linux-gnu
+        run: |
+          sudo apt-get update && sudo apt-get install -yq gcc-aarch64-linux-gnu
+          echo "JEMALLOC_SYS_WITH_LG_PAGE=16" >> $GITHUB_ENV
+          echo "CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=/usr/bin/aarch64-linux-gnu-gcc" >> $GITHUB_ENV
 
       - name: Build
         run: ./scripts/build.sh ${{ matrix.target }}

diff --git a/scripts/build.sh b/scripts/build.sh
@@ -3,7 +3,6 @@ set -euo pipefail
 
 export ARTIFACT_NAME="yazi-$1"
 export YAZI_GEN_COMPLETIONS=1
-export CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=/usr/bin/aarch64-linux-gnu-gcc
 
 # Setup Rust toolchain
 if [[ "$1" == *-musl ]]; then