Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rcirc key-bindings #1008

Closed
luxbock opened this issue Mar 31, 2015 · 2 comments
Closed

Change rcirc key-bindings #1008

luxbock opened this issue Mar 31, 2015 · 2 comments

Comments

@luxbock
Copy link

luxbock commented Mar 31, 2015

The rcirc layer currently uses C-k and C-j to scroll between prev/next input from history. It's also one of the modes that start out in emacs-state by default. This results in us overwriting one of the most used Emacs bindings, C-k for kill-line, which is useful for deleting messages that we changed our mind about while typing.

I suggest changing these to M-k and M-j to avoid this conflict. I'll create a pull-request here but figured I should file an issue as well just for the record.

@luxbock luxbock mentioned this issue Mar 31, 2015
@syl20bnr
Copy link
Owner

syl20bnr commented Apr 1, 2015

I see. C-k C-j should be associated to insert state only.
The default state should be normal in vim style and emacs in emacs style.

@StreakyCobra
Copy link
Contributor

This issue has been solved long ago by the PR #1009, and it's already in master, so closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants