no keybinding to finish magit commit

[tko]

in vim style

1. bring up magit SPC g s
2. stage some changes s
3. commit c c
4. write commit message
5. ???

COMMIT_EDITMSG is in Text mode and there are no obvious keybindings to finish the commit. , says No previous search and SPC m says SPC m is undefined

[justbur]

C-c C-c to commit and C-c C-k to abort both work for me. I'm not sure if there are other bindings for these.

[kritzcreek]

Before 0.103 there was , c c

[tko]

Hmm, so commit and abort are in with-editor-mode(-map) and bunch of commit helpers (adding Acked-by and other git conventions) are in git-commit-mode(-map) -- they're both minor modes which I guess leads to all major mode leader keys being left unmapped :-/

[mightybyte]

I have this problem too. The docs say to use SPC m c c, but as this issue says, SPC m is undefined.

[velppa]

Same thing for me. Using C-c C-C but that's not obvious at all.

[TheBB]

The echo area does say "When done with a buffer, type C-c C-c". The git layer documentation (in develop at least) also says this.

Unfortunately there's no easy way to make a leader key binding just for this buffer any more.

[justbur]

@TheBB I think you should close this

[tasmo]

This is not a keybinding what I expect from SPACEmacs.

[kritzcreek]

tasmo , c works. Just escape to normal Mode and hit , c

[tasmo]

@kritzcreek Wow, that works. Thank you!

[deb0ch]

I usually use SPC b d, just closing the buffer works like a charm because it is the way it works in command-line git

[tasmo]

@deb0ch SPC f s followed by SPC b k didn't work for me. It just does when I call git commit from the command line but not with magit.

[deb0ch]

@tasmo I was talking of SPC b d with a 'd', but maybe you made a typo ?

I'm talking of doing that after editing the commit message when in the COMMIT_EDITMSG buffer-file, opened when pressing c in the *magit-commit-popup* buffer.

[tasmo]

@deb0ch Thank you. It was not a typo. Strange is that SPC b k is killing the buffer and it won't work but with SPC b d. Don't see the logic behind.

[dhanjit]

C-c C-c doesn't work as it does write the commit message however when I do git status from terminal it still says staged but not comited.

[robbert-vdh]

I just close the buffer with ZZ (evil-mode), just like you'd do in command line git.

[HaoZeke]

I think the canonical binding is , , or , c which seem semantic and are still working as of the develop branch. (0.300)

[kreimben]

Save commit messages, press ,.
It works.