u cannot undo emmet-expand-yas insertion

[louy2]

Reproduce steps:

1. web-mode
2. Type html:5
3. Hit TAB, confirm the snippet is expanded
4. Hit ESC to return to normal state
5. Hit u

Expected:
Snippet is deleted.

Actual:
Snippet stays.

Messages:

[yas] Snippet 2 exited.
Undo branch point!

undo-tree-visualize shows that two branches seemingly identical are created right after the snippet is expanded.

[sexptherapy]

I can confirm this.

[Kethku]

This is probably an issue with emmet-mode not spacemacs, and so an issue could be created here: https://github.com/smihica/emmet-mode

[StreakyCobra]

I can't reproduce it any longer, not on develop nor on master. Is someone still encountering this issue?

[louy2]

Still having this problem. Let me update everything and see.

[StreakyCobra]

Ok now I can reproduce it, but I can't tell what was the difference since last time. Doing SPC a u to open the undo tree, it seems expending is doing an additional step (indenting the region) just after. When pressing u, this indenting is undone, but redone just after, making it impossible to go further back in history.

[louy2]

Oh, that's why. I remembered that single-line expansions are free of this problem. Why is the indenting redone just after?

[StreakyCobra]

No idea 😛

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!