Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop - Having NeoTree open makes SPC w = (equalize windows) a noop #2947

Closed
synic opened this issue Sep 8, 2015 · 8 comments
Closed

Develop - Having NeoTree open makes SPC w = (equalize windows) a noop #2947

synic opened this issue Sep 8, 2015 · 8 comments

Comments

@synic
Copy link
Contributor

synic commented Sep 8, 2015

SPC w = normally equalizes your window sizes. However, if you have NeoTree open, SPC w = does nothing.

@syl20bnr
Copy link
Owner

Neotree locks its windows size on purpose, you can use tab to expand it temporarily.

@synic
Copy link
Contributor Author

synic commented Sep 10, 2015

I don't care if NeoTree resizes, but it should probably still resize the other windows.

@TheBB
Copy link
Collaborator

TheBB commented Sep 30, 2015

This should be a feature request for neotree: https://github.com/jaypei/emacs-neotree.

@TheBB TheBB closed this as completed Sep 30, 2015
@synic
Copy link
Contributor Author

synic commented Sep 30, 2015

I think you guys are misunderstanding the issue. This is not a neotree thing, I don't think the neotree author has any control over what SPC w = does.

SPC w = doesn't resize any windows when neotree is open. I don't want it to equalize the neotree window - but it should equalize the other windows.

@TheBB
Copy link
Collaborator

TheBB commented Sep 30, 2015

I was able to reproduce the problem in stock Emacs, so if it's not Neotree's issue, I don't know what. Reported upstream: jaypei/emacs-neotree#132

@TheBB
Copy link
Collaborator

TheBB commented Oct 28, 2015

I haven't gotten any response from the neotree maintainer for a month now. For those interested I recommend you nag @jaypei on jaypei/emacs-neotree#132.

@TheBB TheBB closed this as completed Oct 28, 2015
@jaypei
Copy link
Contributor

jaypei commented Nov 1, 2015

Hi TheBB,

The implementation of balance-windows is horizontal balance and vertical balance,
the trigger condition of these is the "window--resize-apply-p" function return t.
By default, NeoTree window width is locked by using window-size-fixed, so the horizontal balance is ignored.

I will solve this issue ASAP.

jaypei

@TheBB
Copy link
Collaborator

TheBB commented Nov 1, 2015

Cool, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants