The borders of the modeline are gone

[ernestas]

The borders are gone in the develop branch. If this is a feature, please close this issue.

System Info

• OS: gnu/linux
• Emacs: 24.5.1
• Spacemacs: 0.105.0
• Spacemacs branch: develop (rev. bd6716b)
• Distribution: spacemacs
• Layers:

(auto-completion better-defaults emacs-lisp git github restclient org markdown
                 (shell :variables shell-default-height 30 shell-default-position 'bottom)
                 (clojure :variables clojure-enable-fancify-symbols t)
                 javascript)

[TheBB]

We moved away from using our solarized fork and went with the solarized that's on MELPA. What you're probably seeing is the lack of those local modifications we had made. You can modify the modeline faces yourself, of course:

• mode-line
• mode-line-inactive
• powerline-active1 and 2
• powerline-inactive1 and 2

[ernestas]

I have added this:

  (set-face-attribute 'mode-line nil :box '(:color "#839496" :line-width 1))
  (set-face-attribute 'mode-line-inactive nil :box '(:color "#586e75" :line-width 1))
  (set-face-attribute 'powerline-active1 nil :box '(:color "#839496" :line-width 1))
  (set-face-attribute 'powerline-inactive1 nil :box '(:color "#586e75" :line-width 1))
  (set-face-attribute 'powerline-active2 nil :box '(:color "#839496" :line-width 1))
  (set-face-attribute 'powerline-inactive2 nil :box '(:color "#586e75" :line-width 1))

but still not getting the full borders

Will it be possible to pass in the :line-width value with the new theming layer #3486 ?

[TheBB]

That's strange. I don't know why that's not working for you. As for your question, :line-width works fine for me with #3486 and the Monokai theme.

[TheBB]

For the record, that layer is implemented using custom-set-faces and not set-face-attribute. I don't know if it matters. The docstring of the latter seems to imply it's primarily for internal use so I didn't want to touch it.

[TheBB]

I just tried with solarized light and I can reproduce your issue. Must be something weird about that theme. I get the same with solarized dark.

[razum2um]

same with solarized (both themes)
it's definitely something wrong with them as sanityinc-solarized-dark works (both)

[ernestas]

bbatsov/solarized-emacs#174 looks related.

[robbyoconnor]

I have since moved away from solarized -- I didn't like how it handled magit...so I now use monokai...It's not my favorite but it doesn't make my eyes bleed either...

[TheBB]

I think this can be closed now.