ENH Add generic types #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/6/add-generics
branch
from
b4c8bc8
to
5b3bd5f
Compare
emteknetnz
requested changes
Jan 23, 2024
| @@ -20,6 +20,9 @@ | |||
| * @license BSD License (http://silverstripe.org/bsd-license/) | |||
| * @package advancedworkflow | |||
| * @subpackage actions | |||
| * | |||
| * @method \SilverStripe\ORM\ManyManyList<Member> Users() | |||
| * @method \SilverStripe\ORM\ManyManyList<Group> Groups() | |||
There was a problem hiding this comment.
Should import ManyManyList rather than have the full FQCN here
There was a problem hiding this comment.
That's not how we did them previously, but I'll make the change to avoid ping pong (and cause I happen to prefer that anyway)
Done
src/DataObjects/WorkflowAction.php
Outdated
| * | ||
| * @method WorkflowDefinition WorkflowDef() | ||
| * @method Member Member() | ||
| * @method \SilverStripe\ORM\HasManyList<WorkflowTransition> Transitions() |
There was a problem hiding this comment.
Import HasManyList rather than use FQCN
| * @method \SilverStripe\ORM\HasManyList<WorkflowAction> Actions() | ||
| * @method \SilverStripe\ORM\HasManyList<WorkflowInstance> Instances() | ||
| * @method \SilverStripe\ORM\ManyManyList<Member> Users() | ||
| * @method \SilverStripe\ORM\ManyManyList<Group> Groups() |
src/DataObjects/WorkflowInstance.php
Outdated
| @@ -41,6 +41,9 @@ | |||
| * @method WorkflowDefinition Definition() | |||
| * @method WorkflowActionInstance CurrentAction() | |||
| * @method Member Initiator() | |||
| * @method \SilverStripe\ORM\HasManyList<WorkflowActionInstance> Actions() | |||
| * @method \SilverStripe\ORM\ManyManyList<Member> Users() | |||
| * @method \SilverStripe\ORM\ManyManyList<Group> Groups() | |||
| * @method WorkflowAction Action() | ||
| * @method WorkflowAction NextAction() | ||
| * @method \SilverStripe\ORM\ManyManyList<Member> Users() | ||
| * @method \SilverStripe\ORM\ManyManyList<Group> Groups() |
| @@ -35,6 +36,11 @@ | |||
| * @author marcus@symbiote.com.au | |||
| * @license BSD License (http://silverstripe.org/bsd-license/) | |||
| * @package advancedworkflow | |||
| * | |||
| * @method WorkflowDefinition WorkflowDefinition() | |||
| * @method \SilverStripe\ORM\ManyManyList<WorkflowDefinition> AdditionalWorkflowDefinitions() | |||
GuySartorelli
force-pushed
the
pulls/6/add-generics
branch
from
5b3bd5f
to
1a35e0f
Compare
emteknetnz
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 for these generics to take effect.
There were some missing
@methodannotations as well.Issue