Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unicode data #494

Closed
wants to merge 1 commit into from
Closed

Update unicode data #494

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

No description provided.

stof

This comment was marked as resolved.

@nicolas-grekas
Copy link
Member Author

@TRowbotham would you be up to give me some help on the IDN topic again?
The test suite we added in #267 makes maintaining the corresponding polyfill very hard because it's not possible to have the implementation in sync with the latest Unicode data.
Instead, I think we should have a limited set of data to test that works with all php/icu versions so that we can be reasonably confident about the polyfill without proving we're cutting edge data-wise.

@TRowbotham
Copy link
Contributor

@TRowbotham would you be up to give me some help on the IDN topic again? The test suite we added in #267 makes maintaining the corresponding polyfill very hard because it's not possible to have the implementation in sync with the latest Unicode data. Instead, I think we should have a limited set of data to test that works with all php/icu versions so that we can be reasonably confident about the polyfill without proving we're cutting edge data-wise.

Using a small subset of test data makes sense given the challenges of the implementation and data may not be in sync. I can take a look over the weekend to see what subset might work for this

@nicolas-grekas
Copy link
Member Author

It looks like not doing anything might be the best course of action - IDN tests pass at the moment :)

@stof
Copy link
Member

stof commented Sep 10, 2024

Maybe we should have 2 sets of tests:

  • a basic set of tests that can run on any php/icu versions
  • the full tests running when the ICU version matches.

the CI would then force the version of ICU being used (similar to what the symfony/intl testsuite does)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants