Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symfony/console recipe needs symfony/runtime as a dependency #992

Closed
DanielBadura opened this issue Aug 30, 2021 · 2 comments
Closed

symfony/console recipe needs symfony/runtime as a dependency #992

DanielBadura opened this issue Aug 30, 2021 · 2 comments

Comments

@DanielBadura
Copy link

Hello here 👋
I just update some recipes via composer recipes:install --force -v vendor/package-name and a part of it was to update the symfony/console recipe (5.3.7). Now this concluded in a change of the bin/console file since #787 to use the runtime component.

To this point everything is fine, im just wondering if the recipe should use something which is not a dependency by the library itself. Because symfony/console is not requiring symfony/runtime i get now an error that the component is missing. I mean this is a simple fix to require the runtime component for sure but should the recipe have such an indirect dependency?

@nicolas-grekas
Copy link
Member

Recipes can't help here as they don't define deps between packages they relate to.
I guess we cannot do anything, especially since this is a once in years kind of issue.

@DanielBadura
Copy link
Author

I'm not so familiar with the recipes etc. just wondering if there is a possibility with checking if symfony/console and symfony/runtime is installed, then put these things there or something as a meta-recipe thing.

But im fine with "wont fix" was more a meta question :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants