From 183be7d7746332dd028a8344abcb51e9e52e1b57 Mon Sep 17 00:00:00 2001 From: Javier Eguiluz Date: Mon, 14 Mar 2016 13:18:10 +0100 Subject: [PATCH] Removed the PR table example (this is now included by GitHub template) --- contributing/code/patches.rst | 47 +++-------------------------------- 1 file changed, 4 insertions(+), 43 deletions(-) diff --git a/contributing/code/patches.rst b/contributing/code/patches.rst index 1f9bf7000e5..cd2ba03452e 100644 --- a/contributing/code/patches.rst +++ b/contributing/code/patches.rst @@ -268,49 +268,10 @@ pull request message, like in: [Yaml] fixed something [Form] [Validator] [FrameworkBundle] added something -The pull request description must include the following checklist at the top -to ensure that contributions may be reviewed without needless feedback -loops and that your contributions can be included into Symfony as quickly as -possible: - -.. code-block:: text - - | Q | A - | ------------- | --- - | Bug fix? | [yes|no] - | New feature? | [yes|no] - | BC breaks? | [yes|no] - | Deprecations? | [yes|no] - | Tests pass? | [yes|no] - | Fixed tickets | [comma separated list of tickets fixed by the PR] - | License | MIT - | Doc PR | [The reference to the documentation PR if any] - -An example submission could now look as follows: - -.. code-block:: text - - | Q | A - | ------------- | --- - | Bug fix? | no - | New feature? | no - | BC breaks? | no - | Deprecations? | no - | Tests pass? | yes - | Fixed tickets | #12, #43 - | License | MIT - | Doc PR | symfony/symfony-docs#123 - -The whole table must be included (do **not** remove lines that you think are -not relevant). For simple typos, minor changes in the PHPDocs, or changes in -translation files, use the shorter version of the check-list: - -.. code-block:: text - - | Q | A - | ------------- | --- - | Fixed tickets | [comma separated list of tickets fixed by the PR] - | License | MIT +The default pull request description contains a table which you must fill in +with the appropriate answers. This ensures that contributions may be reviewed +without needless feedback loops and that your contributions can be included into +Symfony as quickly as possible: Some answers to the questions trigger some more requirements: