Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook article "How to use the Virtual Form Field Option" not accessible #2846

Closed
xabbuh opened this issue Jul 22, 2013 · 8 comments
Closed

Comments

@xabbuh
Copy link
Member

xabbuh commented Jul 22, 2013

When trying to access the cookbook article How to use the Virtual Form Field Option (for example by using the link in the form Field Type reference) one is always redirected to the inherit_data option article (which doesn't exist in 2.2).

@stof
Copy link
Member

stof commented Jul 22, 2013

@fabpot It looks like the redirection_map of the master branch is used for all versions of the doc instead of using the redirection map of the version being accessed.

@wouterj Please tag this issue as website

@fabpot
Copy link
Member

fabpot commented Jul 22, 2013

There is only one redirection map used for everything, not one per version.

@wouterj
Copy link
Member

wouterj commented Jul 24, 2013

Same as #2655 , but I leave this one open, as there is some more discussion here.

@fabpot is their no way to have a redirection map on a version bases?

@weaverryan if it's not, we have to remove the redirection do you think this is a real issue?

@weaverryan
Copy link
Member

Hi guys!

If it's possible to have the redirect map only redirect if the page isn't found, that would give us some more flexibility. But, I don't know how much work that would be and we're all busy, so assuming that doesn't happen, my vote would be to remove the redirect option. Since this is only a problem when we move pages in one version but not another, we could potentially add a page that says, for example, "The Virtual Form field was changed to Inherit Data in Symfony 2.3". Later, once 2.2 is deprecated (i.e. the last version with the old name), we could either leave things or delete the page and add the redirect map then.

How does that sound? If it sounds good, we should re-add the pages for any "old" pages with the message that links to the new page and remove the entry from the redirection map. If we want to remove the page later, then we should add that to our docs release process.

Thanks!

@wouterj
Copy link
Member

wouterj commented Jul 24, 2013

I don't like those “non-redirecting redirecting pages” suggested by ryan. But I can imagine that it's the only "real" solution.

However, my first preference is using redirection, one way or the other.


Van: Ryan Weaver
Verzonden: ‎woensdag‎ ‎24‎ ‎juli‎ ‎2013 ‎21‎:‎16
Aan: symfony/symfony-docs
CC: Wouter J

Hi guys!

If it's possible to have the redirect map only redirect if the page isn't found, that would give us some more flexibility. But, I don't know how much work that would be and we're all busy, so assuming that doesn't happen, my vote would be to remove the redirect option. Since this is only a problem when we move pages in one version but not another, we could potentially add a page that says, for example, "The Virtual Form field was changed to Inherit Data in Symfony 2.3". Later, once 2.2 is deprecated (i.e. the last version with the old name), we could either leave things or delete the page and add the redirect map then.

How does that sound? If it sounds good, we should re-add the pages for any "old" pages with the message that links to the new page and remove the entry from the redirection map. If we want to remove the page later, then we should add that to our docs release process.

Thanks!


Reply to this email directly or view it on GitHub.

@xabbuh
Copy link
Member Author

xabbuh commented Sep 12, 2013

Any news on this?

@weaverryan
Copy link
Member

I still think we should go for my proposal. The problem with having a redirection map on a version-by-version basis is that this is work that Fabien would need to do, and it's for an edge-case. If he has time to do it, awesome, but I think we should just work around it :).

@xabbuh
Copy link
Member Author

xabbuh commented Sep 13, 2013

I'm fine with your suggestion. It's not the best as @wouterj stated, but it's working. That's even better than what we currently have. :) Although I'd not remove the entire redirection map, but just the entry for the inherit_data option. As far as I can see the other redirections work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants