-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BestPractices] restructured text format for the installation instructions template #5283
Conversation
xabbuh
commented
May 23, 2015
Q | A |
---|---|
Doc fix? | no |
New docs? | no |
Applies to | all |
Fixed tickets |
// ... | ||
} | ||
``` | ||
.. code-block:: markdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one has to be restructuredText?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed
1c79755
to
8845da0
Compare
@wouterj Though I am not sure if this can merged as is due to the changes to the @javiereguiluz What do you think? |
I think this is great! Thanks @xabbuh |
@javiereguiluz I mean, will this work with the current config of the build server? Or do we need to wait for an update of the config before being able to merge this? |
I've just created a pull request in the private Sphinx parser to replicate the changes you made on this PR. I think Fabien will merge them soon and then, the server will be ready to process these changes. |
Thank you @javiereguiluz. |
👍 (and IIRC, the PR on symfony.com was merged?) |
@wouterj yes, it was merged on Saturday morning, so things should be ready by now. |
Let's try it :) Thanks for creating this PR Christian! |
…lation instructions template (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [BestPractices] restructured text format for the installation instructions template | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | Commits ------- 8845da0 [BestPractices] restructured text format for the installation instructions template
@javiereguiluz It looks like the documentation has not been build since this merge or we don't see the build errors anymore here. |