Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BestPractices] restructured text format for the installation instructions template #5283

Merged
merged 1 commit into from
May 25, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 23, 2015

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets

// ...
}
```
.. code-block:: markdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one has to be restructuredText?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@xabbuh xabbuh force-pushed the rst-installation-template branch from 1c79755 to 8845da0 Compare May 23, 2015 08:08
@xabbuh
Copy link
Member Author

xabbuh commented May 23, 2015

@wouterj Though I am not sure if this can merged as is due to the changes to the conf.py file.

@javiereguiluz What do you think?

@javiereguiluz
Copy link
Member

I think this is great! Thanks @xabbuh

@xabbuh
Copy link
Member Author

xabbuh commented May 23, 2015

@javiereguiluz I mean, will this work with the current config of the build server? Or do we need to wait for an update of the config before being able to merge this?

@javiereguiluz
Copy link
Member

I've just created a pull request in the private Sphinx parser to replicate the changes you made on this PR. I think Fabien will merge them soon and then, the server will be ready to process these changes.

@xabbuh
Copy link
Member Author

xabbuh commented May 23, 2015

Thank you @javiereguiluz.

@wouterj wouterj removed the On hold label May 25, 2015
@wouterj
Copy link
Member

wouterj commented May 25, 2015

👍 (and IIRC, the PR on symfony.com was merged?)

@javiereguiluz
Copy link
Member

@wouterj yes, it was merged on Saturday morning, so things should be ready by now.

@wouterj
Copy link
Member

wouterj commented May 25, 2015

Let's try it :) Thanks for creating this PR Christian!

@wouterj wouterj merged commit 8845da0 into symfony:2.3 May 25, 2015
wouterj added a commit that referenced this pull request May 25, 2015
…lation instructions template (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[BestPractices] restructured text format for the installation instructions template

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

8845da0 [BestPractices] restructured text format for the installation instructions template
@xabbuh xabbuh deleted the rst-installation-template branch May 25, 2015 08:32
@xabbuh
Copy link
Member Author

xabbuh commented May 26, 2015

@javiereguiluz It looks like the documentation has not been build since this merge or we don't see the build errors anymore here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants