Overriding 3rd party bundles #5290
Conversation
anacicconi
commented
May 23, 2015
anacicconi
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #4635 |
|
👍 |
|
|
||
| Another reason to create a new bundle is when you're overriding something | ||
| in a vendor's bundle. For instance, if you have to override an action of | ||
| the FOSUserBundle, then you should create a UserBundle that would be used |
There was a problem hiding this comment.
I suggest using a different example than FOSUserBundle. Once I finally release its 2.0 version, people would generally not need to overwrite our actions, because we provide lots of extension points in them. And overwriting FOSUserBundle 2 actions is the worse way to change the behavior.
There was a problem hiding this comment.
I took out the example here in sha: c24862b, but we still have it in the linked doc. I don't think it's a huge deal, but if we can think of an easy other example, that'd be cool.
And btw - this is an awesome problem to have 👍. I hate overriding bundle controllers - it's almost always a problem when upgrading. So, I like the FOSU events a lot
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5290). Discussion ---------- Overriding 3rd party bundles | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4635 Commits ------- 58bb3c5 overriding 3rd party bundles
|
Thanks you very much Ana! I've merged this into the 2.3 branch with only a minor tweak at sha: c24862b Another issue down :) |
