Added support for standard Forwarded header #5382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Most reverse proxies store information on specific ``X-Forwarded-*`` headers. | ||
| But if your reverse proxy uses non-standard header names, you can configure | ||
| Although `RFC 7239`_ recently defined a standard ``Forwarded`` header to disclose | ||
| all proxy information, most reverse proxies store information on non-standard |
There was a problem hiding this comment.
[...] information in non-standard [...]
| ``X-Forwarded-For`` header. | ||
|
|
||
| .. versionadded:: 2.7 | ||
| ``Forwarded`` header support was introduced in Symfony 2.7 |
There was a problem hiding this comment.
missing period at the end of the sentence
There was a problem hiding this comment.
Nice catch. Fixed. Thanks.
|
👍 |
|
Thanks Javier! Even though this mentions a 2.7 feature, I merged it into the 2.3 branch, because we never actually show any functions that don't exist in 2.3, and because we're mostly talking about something that's universally true (and someone using 2.3 might want to know that the Forwarded header does have support in a later version). Cheers! |
weaverryan
added a commit
that referenced
this pull request
Jun 28, 2015
…aviereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Added support for standard Forwarded header | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.7+ | Fixed tickets | - This PR finishes the work made by @tony-co in #4266. Commits ------- 8928049 Fixed a minor grammar issue 319c081 Fixed a minor grammar issue ac3689b Added support for standard Forwarded header d452137 Added support for standard Forwarded header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the work made by @tony-co in #4266.