Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename annotations to attributes in AttributeLoader #58585

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #...
License MIT

Annotations are not supported anymore in AttributeLoader, so we can rename some variables

@carsonbot carsonbot added this to the 7.2 milestone Oct 16, 2024
@alamirault alamirault changed the title [Serializerg] Rename annotations to attributes in AttributeLoader [Serializerg] Rename annotations to attributes in AttributeLoader Oct 16, 2024
@welcoMattic welcoMattic changed the title [Serializerg] Rename annotations to attributes in AttributeLoader [Serializer] Rename annotations to attributes in AttributeLoader Oct 17, 2024
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(rebase needed)

@carsonbot carsonbot changed the title [Serializer] Rename annotations to attributes in AttributeLoader Rename annotations to attributes in AttributeLoader Oct 23, 2024
@alamirault alamirault force-pushed the feature/rename-annotation-to-attribute-serializer branch from d42187f to 9ab0752 Compare October 25, 2024 18:11
@alamirault
Copy link
Contributor Author

I rebased branch

@nicolas-grekas
Copy link
Member

Thank you @alamirault.

@nicolas-grekas nicolas-grekas merged commit c2cb583 into symfony:7.2 Nov 5, 2024
9 of 10 checks passed
@alamirault alamirault deleted the feature/rename-annotation-to-attribute-serializer branch November 5, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants