Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file remove and rename command #30

Open
lordi opened this issue Jul 30, 2017 · 3 comments
Open

Add file remove and rename command #30

lordi opened this issue Jul 30, 2017 · 3 comments

Comments

@lordi
Copy link
Contributor

lordi commented Jul 30, 2017

There should be two commands (remove and rename) to allow the user to explicitly handle file changes.

@bakkdoor
Copy link
Member

What do you think of these changes to the protocol?

Rename a file

{:rename, old_hash, new_hash}
-> {:ok} | {:error, reason}

I'm not sure how we want to deal with renaming a file.. Do we end up changing all revisions and pretend they all were for a file with the new hash? Not sure if that even works with the current way we encrypt files. I'd assume we'd need to at least re-upload the metadata along with the new hash for the encryption to work out?

Delete a file (and all its revisions)

{:delete_file hash}
-> {:ok} | {:error, reason}

@lordi
Copy link
Contributor Author

lordi commented Mar 16, 2018

As for renaming, thats a good question. I think intuitively I'm against just renaming all revisions, but it has alot of benefits (eg. the history of the file is retained).

We indeed need to re-upload the metadata because the filename inside of it changed obviously.

@lordi
Copy link
Contributor Author

lordi commented Jun 22, 2018

Delete file is implemented in Branch sign-chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants