Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises status .status.status can be renamed #115

Open
ChunyiLyu opened this issue May 1, 2024 · 1 comment
Open

Promises status .status.status can be renamed #115

ChunyiLyu opened this issue May 1, 2024 · 1 comment

Comments

@ChunyiLyu
Copy link
Member

ChunyiLyu commented May 1, 2024

Promises have a .status.status field that can be set to either Available or Unavailable. We should think about renaming/refactor this field because status.status reads redundant and a bit awkward

status implies that there could be multiple state rather than Available or Unavailable. If all we want to express is if this promise is available or not, this can be better expressed as a bool, e.g. .status.available or .status.ready

@kirederik
Copy link
Member

agree, a bit redundant;

the status field is, sometimes, "Error" or some other status. Any suggestion on how to deal with that (or how to make it look nice on k get promises)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants