Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate promise resources finalisers #99

Open
kirederik opened this issue Mar 28, 2024 · 0 comments
Open

chore: consolidate promise resources finalisers #99

kirederik opened this issue Mar 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kirederik
Copy link
Member

as part of #90, we introduced more deterministic labels into the resources that get created when a promise is installed.

as part of this chore, let's consolidate the deletion of all Promise k8s resources within the Promise Controller into a single finalizer (i.e. Jobs, ServiceAccounts, ClusterRoles, ClusterRoleBindings, ConfigMaps, Works). Those resources should all have a kratix.io/promise-name that can be used.

🚨 This may introduce a breaking change, depending on how it's implemented

@kirederik kirederik added the blocked extra chat is needed label Mar 28, 2024
@kirederik kirederik added this to the multiple-workflows milestone Apr 10, 2024
@kirederik kirederik added the enhancement New feature or request label Apr 10, 2024
@richcooper95 richcooper95 removed this from the multiple-workflows milestone Apr 25, 2024
@kirederik kirederik removed the blocked extra chat is needed label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants