Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing package dependency #8

Closed
smoke-indica opened this issue Feb 27, 2020 · 1 comment
Closed

Missing package dependency #8

smoke-indica opened this issue Feb 27, 2020 · 1 comment
Labels
☂️ area/types This affects typings 🙋 no/question This does not need any changes

Comments

@smoke-indica
Copy link

Subject of the issue

Missing package dependency.

Your environment

  • OS: Windows
  • Packages: 3.0.1
  • Env: node v12.14.0 , npm 6.13.4

Steps to reproduce

import {Node} from 'unist'

import {Node} from 'unist'

unist isn't included as a dependency in packages.json

Tried to use v3 in place of v2 in gatsby-remark-images-anywhere, got a warning about missing package dependencies.

Expected behaviour

required package dependency stored in packages.json

Actual behaviour

Missing package dependency, fails to run

@smoke-indica smoke-indica added 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info labels Feb 27, 2020
@ChristianMurphy
Copy link
Member

We've avoided adding direct dependencies on @types/ packages due to the issues outlined in unifiedjs/unified#45 .
When using Typescript add the unist typings using npm install @types/unist.

@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🙋 no/question This does not need any changes 🙅 no/wontfix This is not (enough of) an issue for this project and removed 🐛 type/bug This is a problem 🙉 open/needs-info This needs some more info 🙅 no/wontfix This is not (enough of) an issue for this project labels Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 🙋 no/question This does not need any changes
Development

No branches or pull requests

2 participants