Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support ignoring fields when serializing #262

Merged
merged 8 commits into from
Jun 12, 2020
Merged

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Jun 9, 2020

Description

Adds exclude predicate to serializer for skipping properties before serializing

Related Issues

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

Example
https://github.com/tophat/syrupy/blob/3dd24de6cb8df5f79b27b270796af45639b94dbf/tests/test_filters.py#L13-L20
https://github.com/tophat/syrupy/blob/3dd24de6cb8df5f79b27b270796af45639b94dbf/tests/__snapshots__/test_filters.ambr#L9-L18

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        19    +1     
  Lines          939       949   +10     
=========================================
+ Hits           939       949   +10     

@iamogbz iamogbz requested a review from noahnu June 9, 2020 14:26
Copy link
Collaborator

@noahnu noahnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is great

@iamogbz iamogbz merged commit f67268e into master Jun 12, 2020
@iamogbz iamogbz deleted the property-filter branch June 12, 2020 02:08
syrupy-bot pushed a commit that referenced this pull request Jun 12, 2020
## [0.5.1](v0.5.0...v0.5.1) (2020-06-12)

### Bug Fixes

* support ignoring fields when serializing ([#262](#262)) ([f67268e](f67268e))
@syrupy-bot
Copy link
Contributor

🎉 This PR is included in version 0.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ignoring fields when serializing
3 participants