Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amber): Do not add empty line to empty iterables #287

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Jul 9, 2020

Description

Fixes the amber data serializer

Related Issues

Introduced in #245

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

No additional comments.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #287   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          949       951    +2     
=========================================
+ Hits           949       951    +2     

@iamogbz iamogbz marked this pull request as ready for review July 9, 2020 13:50
@iamogbz iamogbz requested a review from noahnu July 9, 2020 13:50
Copy link
Collaborator

@noahnu noahnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shocked we didn't have this coverage before. This is why we need 200% coverage as our target 😄

@iamogbz iamogbz merged commit 0b4a9b0 into master Jul 9, 2020
@iamogbz iamogbz deleted the fix-extra-line branch July 9, 2020 14:44
syrupy-bot pushed a commit that referenced this pull request Jul 9, 2020
## [0.5.2](v0.5.1...v0.5.2) (2020-07-09)

### Bug Fixes

* **amber:** Do not add empty line to empty iterables ([#287](#287)) ([0b4a9b0](0b4a9b0))
@syrupy-bot
Copy link
Contributor

🎉 This PR is included in version 0.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants