refactor: optimise session data structures #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1001 1023 +22
=========================================
+ Hits 1001 1023 +22 |
iamogbz
commented
Oct 30, 2020
iamogbz
commented
Oct 30, 2020
Comment on lines
-31
to
+34
| _all_items: Dict["pytest.Item", bool] = attr.ib(factory=dict) | ||
| _collected_items: Set["pytest.Item"] = attr.ib(factory=set) | ||
| # All the selected test items. Will be set to False until the test item is run. | ||
| _ran_items: Dict["pytest.Item", bool] = attr.ib(factory=dict) | ||
| _selected_items: Dict[str, bool] = attr.ib(factory=dict) |
There was a problem hiding this comment.
This assumes that collected items are a superset of selected items, hence no need to duplicate the references. And using the node ids to save run state, allows easy lookup inran_item(...) usage.
iamogbz
commented
Oct 30, 2020
Comment on lines
+66
to
+68
| _collected_items_by_nodeid: Dict[str, "pytest.Item"] = attr.ib( | ||
| factory=dict, init=False | ||
| ) |
There was a problem hiding this comment.
This is generated once at instantiation, and used to easily map selected item nodes to collected pytest items.
noahnu
approved these changes
Oct 30, 2020
syrupy-bot
pushed a commit
that referenced
this pull request
Oct 30, 2020
## [0.8.4](v0.8.3...v0.8.4) (2020-10-30) ### Performance Improvements * optimise session items data structures ([#403](#403)) ([818d405](818d405))
|
🎉 This PR is included in version 0.8.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Additional Comments
No additional comments.