Snapshots using JSONSnapshotExtension are deleted when they should not be

[FRidh]

Describe the bug

I migrated from AmberSnapshotExtension to JSONSnapshotExtension. Updating after the initial conversion I get

9 snapshots generated. 9 unused snapshots deleted.

There are 9 snapshots, it regenerates all of them and then deletes them.

In another case it would delete all 9, but then recreate 1 but in not in the __snapshots__ folder directly, but in a folder __snapshots__/test_filename where test_filename is the name of the test script. The snapshot itself had the correct filename.

To reproduce

Steps to reproduce the behavior:

1. Create tests with JSONSnapshotExtension
2. Run pytest --snapshot-update and commit
3. Rerun pytest --snapshot-update without actually having made any changes.
4. Get 9 snapshots generated. 9 unused snapshots deleted. and indeed all your snapshots deleted.

Expected behavior

Not deleting snapshots that are still being used.

Screenshots

Environment (please complete the following information):

• OS: NixOS 22.11
• Syrupy Version: 4.0.2
• Python Version: 3.11.3

Additional context

[tophat-opensource-bot]

🎉 This issue has been resolved in version 4.0.4 🎉

The release is available on:

• v4.0.4
• GitHub release

Your semantic-release bot 📦🚀