Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaled control coefficients fail with zero rates. #1031

Closed
luciansmith opened this issue Jun 30, 2022 · 2 comments
Closed

Scaled control coefficients fail with zero rates. #1031

luciansmith opened this issue Jun 30, 2022 · 2 comments

Comments

@luciansmith
Copy link

When a reaction rate is zero, we can't scale the control coefficient, so right now, we throw an error and refuse to do anything. Copasi gives all zeroes except for the scaled-with-itself rate, which it sets at 1, and JWS online sets everything to zero. We should do what JWS Online does, at least pending further investigation.

@luciansmith
Copy link
Author

Fixed for now with 6846962 but we want to investigate more; leaving this open for now.

@luciansmith
Copy link
Author

Fixed by adding the flux threshold value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant