No hostname check ssl opt #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
CedricArickx
approved these changes
Sep 8, 2023
|
Thanks for the review @CedricArickx we will need a news entry and then it is ready for merge. |
…ignalData Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Error message: "Certificate subject does not match configured hostname;" In some cases you want to verify the ssl certificate authenticity but don't care about a mismatched hostname. For example when using self-signed certificates that don't contain a hostname at all. Currently there is no way to do this except for simply not verifying the certificate at all. This option disables the ssl certificate hostname check, but still does all other verification steps. Signed-off-by: Cedric Arickx <cedric.arickx@gmail.com> Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
no-hostname-check-ssl-opt
branch
from
c73a150
to
91d5785
Compare
|
rebased and added news file. I opened this PR but this can be approved as the code was initially written by @CedricArickx @alltilla or @MrAnno please help by approving it (if everything remains green) Thanks. |
MrAnno
approved these changes
Sep 20, 2023
fekete-robert
pushed a commit
to axoflow/axosyslog-core-docs
that referenced
this pull request
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat modified version of #4613
@CedricArickx I changed your PR but I didn't want to overwrite it, please review the changes I have made and let me know if you agree. I opened a new PR instead of overwriting yours.