font-edit: Improve the type descriptions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is a lack of description for geometric types and functions. pt_t is used to describe a geometric object—a point, while pts_t is used to describe a dynamically configurable array. n is used to describe the current number of configured points, and s is used to describe the maximum configurable memory limit, measured in bytes. spline_t is used to describe cubic spline interpolation based on four points. new_pts, dispose_pts, and add_pt are methods for the pt_t and pts_t types. distance_to_point, distance_to_line, and distance_to_segment are used to describe the distance relationships between geometric objects. lerp is a function for computing linear interpolation points. fit is used to compute a spline with a specific error tolerance.
jserv
reviewed
Aug 6, 2024
jserv
reviewed
Aug 6, 2024
jserv
changed the title
There are both camelCase and underscore naming styles To maintain consistency, the following variable names are changed: OpMove -> op_move OpLine -> op_line OpCurve -> op_curve OpNoop -> op_noop Additionally, to maintain consistency in the identify of struct, avoid conflicts with alias, the following change is made: _pts_t -> _pts Refs: 1. ISO/IEC 9899:1999 6.7.2.3 Tags 6.7.7 Type definitions
|
Thank @jouae for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the font-edit tool relies on Xlib. According to #7, font-edit should be restructured using SDL2 to enhance portability.
Before proceeding with this work, it is necessary to understand the significance and operational principles of TWIN’s existing functionality. Therefore, we first need to add clear comments to the typedefs and functions in twin-fedit.h to provide a basis for future modifications and porting to SDL2.
To avoid disrupting other developers who might be using the tool during this process, a new branch named font-edit is created.