Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Misplaced if-else clause in volunteer sign up template #336

Closed
smarshy opened this issue Jun 11, 2016 · 4 comments
Closed

Misplaced if-else clause in volunteer sign up template #336

smarshy opened this issue Jun 11, 2016 · 4 comments
Labels
Type: Enhancement New feature or request.

Comments

@smarshy
Copy link
Contributor

smarshy commented Jun 11, 2016

The error message should be displayed if there are errors. The if else statements seem to be switched in this line onwards for resume field on volunteer registration form

@tapaswenipathak
Copy link
Contributor

@smarshy You mean the error messages are not coming up during volunteer sign up due to the misplaced if else clause, is it?

Do you think #305 is because of this?

@smarshy
Copy link
Contributor Author

smarshy commented Jun 12, 2016

@yES, and they are coming up for resume even if they are no errors for resume field. I was using selenium to count the number of error boxes on the page to verify when I entered wrong inputs for some of the fields and I kept getting an extra box count returned for volunteer. That is when I found this incorrect clause.

Regarding the error, I don't feel that is a direct consequence of this. In the tests too, I see that tests for resume were commented out, saying that they should be tested locally. So, i think problem here is due to some other bug.

@shubham2892
Copy link

Is this bug still open, would love to take a hit if it's okay.

@tapaswenipathak
Copy link
Contributor

tapaswenipathak commented Aug 23, 2016

@shubham2892 Sure, please go ahead.

necessary129 referenced this issue in necessary129/vms Nov 29, 2016
closes #336
necessary129 referenced this issue in necessary129/vms Nov 29, 2016
Closes #336
@tapaswenipathak tapaswenipathak added Easy Type: Enhancement New feature or request. labels Nov 30, 2016
@mayburgos mayburgos added the gci16 label Dec 6, 2016
kriti21 referenced this issue in kriti21/vms Feb 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

4 participants