This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
Added and extended tests for shift #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.4%) to 83.717% when pulling 5359c141ee469d6fc3cfbc3f73f73a08b3204eaa on smarshy:extendUnit into 2fb0d11 on systers:develop. |
|
|
||
| # commented out due to bug | ||
| # self.assertEqual(end_time, report_1[0]["logged_end_time"]) | ||
| # self.assertEqual(1.0, report_1[0]["duration"]) |
There was a problem hiding this comment.
@smarshy Do we have a issue open for this bug you are referring to?
There was a problem hiding this comment.
@tapasweni-pathak Yes. For both, it is issue #327
Logged times are different and hence, duration is incorrect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #346