Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing a task does not add a Done date #10

Open
1 task done
claremacrae opened this issue Jun 26, 2022 · 6 comments
Open
1 task done

Completing a task does not add a Done date #10

claremacrae opened this issue Jun 26, 2022 · 6 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@claremacrae
Copy link
Contributor

I was excited to try out the new Tasks Status Types. Thank you for working on these.

Expected Behavior

Installing this plugin and accepting its default settings, I would expect that clicking in the Task's checkbox would mark the task as done and add the Done date.

Current Behavior

Instead of change [ ] to [x] it changes to [/], which the settings say is 'In Progress'. And it therefore does not add the Done date, regardless of whether the user enabled that field or not.

It looks like it is a completed task, but it actually is not.

Problems with this behaviour include:

  • It seems to silently impose on the user the requirement to install special styling to show the in-progress tasks - possibly even imposing Minimal or ITS Themes?
  • It's a change in behaviour when the plugin says it's intended to be backwards-compatible with Tasks.

Steps to Reproduce

  • Install v2.4.2 of this plugin
  • Create a task e.g. - [ ] Do stuff
  • Switch to Reading mode
  • Click on the task's check box

Result is: - [/] Do Stuff

Context (Environment)

  • Obsidian version: 0.15.2
  • Tasks-X version: 2.4.2
  • I have tried it with all other plugins disabled and the error still occurs

Possible Solution

  • Change the default states to be as per the current Obsidian and Tasks plugin defaults, namely [ ] and [x] only
  • And make it easy to add the 'In progress' state in the settings, for those who would like this feature
@sytone
Copy link
Owner

sytone commented Jun 29, 2022

Thanks for the feedback, I will move the default progress from [ ] -> [x] -> [ ] and then add the custom state of in progress as an option to the UI.

As for styling I am happy to support any style, I am using existing ones as I do not want to re-make the css styles and then keep them in sync with themes. Happy for any suggestions or ideas on this point. The default obsidian theme just has done and not done.

@claremacrae
Copy link
Contributor Author

Thanks for the feedback, I will move the default progress from [ ] -> [x] -> [ ] and then add the custom state of in progress as an option to the UI.

Perfect. Thanks very much.

As for styling I am happy to support any style, I am using existing ones as I do not want to re-make the css styles and then keep them in sync with themes. Happy for any suggestions or ideas on this point. The default obsidian theme just has done and not done.

I'll have a think about options for that.

For example, if it's possible to adding custom task styling via snippets, we can point people to those in the settings, when they turn on the new states.

@sytone
Copy link
Owner

sytone commented Jun 29, 2022

Yes, this is a option, if you know of a good snippet to use as a reference please shout out.

@claremacrae
Copy link
Contributor Author

I looked briefly the other day without success. Will try to try again.

@sytone sytone added enhancement New feature or request bug Something isn't working labels Jun 29, 2022
@claremacrae
Copy link
Contributor Author

This is a popular checkboxes set that I have started experimenting with:
https://github.com/SlRvb/Obsidian--ITS-Theme/blob/main/Guide/Alternate-Checkboxes.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants