Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type 'unique symbol' is not assignable to type 'number' #18

Closed
aalemayhu opened this issue Jun 3, 2019 · 4 comments · Fixed by #19
Closed

Type 'unique symbol' is not assignable to type 'number' #18

aalemayhu opened this issue Jun 3, 2019 · 4 comments · Fixed by #19

Comments

@aalemayhu
Copy link

Hei,

I was checking out Dinatra and tried using dejs. It was working for me but after upgrading to most recent deno I see the errors below, similiar to the ones from the latest CI failure. Do you have a fix for this?

Cool project, thanks!

deno run --allow-read --allow-net src/main.ts
[0/1] Compiling file:///Users/scanf/src/github.com/scanf/uuid.alemayhu.com/src/main.tshttps://raw.githubuserconte
nt.com/syumai/dejs/master/dejs.ts:99:9 - error TS2469: The '<' operator cannot be applied to type 'symbol'.

99     if (byte < 0) {
           ~~~~
https://raw.githubusercontent.com/syumai/dejs/master/dejs.ts:103:14 - error TS2345: Argument of type 'number | un
ique symbol' is not assignable to parameter of type 'number'.
  Type 'unique symbol' is not assignable to type 'number'.

103     buf.push(byte);
                 ~~~~

make: *** [hello] Error 1
Alexanders-MacBook-Pro:uuid.alemayhu.com scanf$ make
deno run --allow-read --allow-net src/main.ts
[0/1] Compiling file:///Users/scanf/src/github.com/scanf/uuid.alemayhu.com/src/main.tshttps://raw.githubuserconte
nt.com/syumai/dejs/master/dejs.ts:99:9 - error TS2469: The '<' operator cannot be applied to type 'symbol'.

99     if (byte < 0) {
           ~~~~
https://raw.githubusercontent.com/syumai/dejs/master/dejs.ts:103:14 - error TS2345: Argument of type 'number | un
ique symbol' is not assignable to parameter of type 'number'.
  Type 'unique symbol' is not assignable to type 'number'.

103     buf.push(byte);
@syumai
Copy link
Owner

syumai commented Jun 6, 2019

Thank you for reporting this!
I'll take a look at this.

@syumai
Copy link
Owner

syumai commented Jun 6, 2019

This PR caused this problem. I'll fix dejs to handle EOF
denoland/std#472

@syumai
Copy link
Owner

syumai commented Jun 6, 2019

@scanf Resolved in #19, thanks!

@aalemayhu
Copy link
Author

Can confirm it's working.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants