Support X and Y axis flip, mk. 2 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Klaus Kämpf <kkaempf@gmail.com>
Fixes oversight in previous commit.
|
Looks good, please let me know if everything works correctly (cut and engrave match, engrave image not mirrored, ...). |
|
I tested all of this on an OMTech Polar. I could send pictures but I think they wouldn't prove anything (could be mirrored afterwards or so). |
|
That's good. I just asked because recently we had some PRs by someone else where it turned out that the code doesn't work in real life. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another commit to #206 to fix the calculation of the bounding box.