Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revshellgen.py #7

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Update revshellgen.py #7

merged 1 commit into from
Aug 14, 2021

Conversation

JohnRyk
Copy link
Contributor

@JohnRyk JohnRyk commented Aug 11, 2021

No description provided.

@t0thkr1s t0thkr1s self-requested a review August 11, 2021 16:54
@t0thkr1s t0thkr1s self-assigned this Aug 11, 2021
@t0thkr1s
Copy link
Owner

Hi!

First of all, thank you for contributing to the project!
Can you elaborate a bit more on this commit? Correct me if I'm wrong but sys.path[0] returns an empty string which makes no sense adding it before the commands directory path.

Have a great day!

revshellgen.py Show resolved Hide resolved
@JohnRyk
Copy link
Contributor Author

JohnRyk commented Aug 12, 2021

Hi. Thanks for reply. When I using the script I always put it into my "kit" folder such "/home/me/mykit" and create a sort link to the script like "/usr/bin/revshellgen". So when I run the command "revshellgen" the script cannot find the "commands" folder because it dose not in the "/usr/bin" folder. So add "sys.path[0]" and it can return the absolute path when I run the "revshellgen" command.

@t0thkr1s
Copy link
Owner

Thanks for clarifying it! I reviewed and tested the code which actually makes sense and it's a nice little improvement. Adding support is always a good thing, so feel free to make contributions like this. 👍

@t0thkr1s t0thkr1s added the enhancement New feature or request label Aug 14, 2021
@t0thkr1s t0thkr1s merged commit 227137c into t0thkr1s:master Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants