-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std/tokio simple: timeout not working, it is actually None on Drop #12
Comments
You can also remove the |
Hey @beckend thank you so much for pointing this out -- would you be willing to put the changes into a PR? I think the tests wouldn't even have to change -- just the code would be fine! |
Sent the PR. Consider the breaking nature. |
Thanks to the work in the PR and comments, these improvements have all landed in version 0.2.6: https://github.com/t3hmrman/async-dropper/releases/tag/async-dropper-simple-v0.2.6 Thanks! |
https://github.com/t3hmrman/async-dropper/blob/main/crates/async-dropper-simple/src/lib.rs#L65
This line will replace self with Default impl and
timeout
becomes None: https://github.com/t3hmrman/async-dropper/blob/main/crates/async-dropper-simple/src/lib.rs#L61Also as a note, adding Deref and Derefmut would be desirable to get the inner otherwise this Struct is less useful.
The text was updated successfully, but these errors were encountered: