Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] search button / box responsive issues. #508

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

pxamike
Copy link
Contributor

@pxamike pxamike commented Apr 10, 2019

  • search-button in main-navigation is hidden under search-box when language-menu-box is enabled.
  • search-box in header-middle doesn't fit when social-icons are enabled.

Some t3kit components in main-navigation or header-middle work fine by themselves but not in combination with others. This pull request tries to solve search-box related issues above. It also changes header-middle__logo and header-middle__social-icon to width: auto; in 768px screens or larger (or logo + searchbox + social icons will simply not fit).

Testing:

I have tried to test as much as I can to not break other things / other views, but I need a second opinion whether this is deemed [!!!] or not. The following images are showing before, after, before, after my pull request is applied.

Testcase 1:
Shows the issue where search-button in main-navigation is hidden under search-box when language-menu-box is enabled. (see Desktop 2-image)

Typoscript constants:
themes.configuration.isDevelopment = 1
themes.configuration.menu.main.enableLangMenuInNavigation = 1
themes.configuration.elem.status.showHeaderTopSearch = 1
themes.configuration.elem.status.showHeaderTopLangMenu = 1
themes.configuration.elem.status.showHeaderMainMenuSearch = 1
themes.configuration.elem.status.showHeaderTopLangLabel = 1
themes.configuration.elem.status.headerTopNavigationVisibleInMobileMenu = 1

themes.configuration.elem.status.showHeaderMiddleSearch = 0
themes.configuration.elem.status.showHeaderMiddleSocIcons = 0

themes.configuration.socialmedia.useGooglePlus = 0
themes.configuration.socialmedia.useMynewsdesk = 0
themes.configuration.socialmedia.usePinterest = 0
themes.configuration.socialmedia.useTwitter = 1
themes.configuration.socialmedia.useVimeo = 0
themes.configuration.socialmedia.useXing = 0
themes.configuration.socialmedia.useYoutube = 1

Desktop 1
testcase1_desktop1_0
testcase1_desktop1_1_fixed

Desktop 2
testcase1_desktop2_0
testcase1_desktop2_1_fixed

iPad 1
testcase1_ipad_1_0
testcase1_ipad_1_1_fixed

iPad 2
testcase1_ipad_2_0
testcase1_ipad_2_1_fixed

iPad 3
testcase1_ipad_3_0
testcase1_ipad_3_1_fixed

Testcase 2:
Shows the issue that search-box in header-middle doesn't fit when social-icons are enabled.

Typoscript constants:
themes.configuration.isDevelopment = 1
themes.configuration.menu.main.enableLangMenuInNavigation = 1
themes.configuration.elem.status.showHeaderTopSearch = 1
themes.configuration.elem.status.showHeaderTopLangMenu = 1
themes.configuration.elem.status.showHeaderMainMenuSearch = 1
themes.configuration.elem.status.showHeaderTopLangLabel = 1
themes.configuration.elem.status.headerTopNavigationVisibleInMobileMenu = 1

themes.configuration.elem.status.showHeaderMiddleSearch = 1
themes.configuration.elem.status.showHeaderMiddleSocIcons = 1

themes.configuration.socialmedia.useGooglePlus = 0
themes.configuration.socialmedia.useMynewsdesk = 0
themes.configuration.socialmedia.usePinterest = 0
themes.configuration.socialmedia.useTwitter = 1
themes.configuration.socialmedia.useVimeo = 0
themes.configuration.socialmedia.useXing = 0
themes.configuration.socialmedia.useYoutube = 1

Desktop 1
testcase2_desktop_1_0
testcase2_desktop_1_1_fixed

Desktop 2
testcase2_desktop_2_0
testcase2_desktop_2_1_fixed

iPad 1
testcase2_ipad_1_0
testcase2_ipad_1_1_fixed

iPad 2
testcase2_ipad_2_0
testcase2_ipad_2_1_fixed

iPad 3
testcase2_ipad_3_0
testcase2_ipad_3_1_fixed

…x when language-menu-box is enabled.

- search-box in header-middle doesn't fit when social-icons are enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants