[BUGFIX] language menu in main-nav alignment when using dropdownColumns #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #507
The main issue with combining dropdownColumns = 1 and enableLangMenuInNavigation = 1 is that the container that the language-menu is placed in is not a bootstrap-container-width anymore. This is because the dropdown columns needs this condition for the dropdown menus to occupy the full viewport width.
Therefore the open language-menu covers the full width of the viewport. This fix constrains that to Bootstrap-limits but makes sure it still looks the way it did before in viewport widths < 992 px.
Typoscript configuration used
themes.configuration.isDevelopment = 1
themes.configuration.menu.main.enableLangMenuInNavigation = 1
themes.configuration.elem.status.showHeaderTopLangMenu = 1
themes.configuration.elem.status.showHeaderTopSearch = 0
themes.configuration.elem.status.showHeaderMainMenuSearch = 0
themes.configuration.elem.status.showHeaderTopLangLabel = 1
themes.configuration.menu.main.dropdownColumns = 1
Screenshots:
(note1: showHeaderTopLangMenu = 1 is also enabled in the screenshots to have something to compare with)
(note2: the white border of the open language menu in main-navigation was fixed in another pull request, see https://github.com/t3kit/theme_t3kit/pull/502/files#diff-a496fbbc3421dda897c120fdffc0969eR2707 )
Desktop language menu closed before
Desktop language menu closed after
Desktop language menu open before
Desktop language menu open after
Desktop 2 language menu open before
Desktop 2 language menu open after
Tablet language menu open before
Tablet language menu open after
Mobile language menu open before
Mobile language menu open after