Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a simple items blacklist mechanism + fixed saving settings + typo #214

Closed
wants to merge 2 commits into from

Conversation

quadbyte
Copy link
Collaborator

@quadbyte quadbyte commented Sep 25, 2020

Issues

Description

People have been complaining about hitting the max items limitations (Input/Output/Apps) and not seeing the items they would like on their device.
I added a new blacklist textbox at the bottom of the settings. On each line you can enter the name of the item you want to see blacklisted. You need to disconnect / reconnect the device so it forgets all previous item and start fresh.
While I was in there I added a save() for the settings via RaisePropertyChanged() because without it is was too painful to test
Also fixed a minor typo in the colors.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Requested changes are in a branch
  • Compiled and tested requested changes on target hardware (PC, device)
  • Updated the documentation, if necessary
  • Updated the LICENSES file, if necessary
  • Reviewed the guidelines for contributing to this repository

@quadbyte quadbyte closed this Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Output Devices Settings not saved on change
1 participant