Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-toggle-1] Implementation of different toggling patterns require different ARIA attributes #40

Open
FremyCompany opened this issue Sep 16, 2022 · 2 comments

Comments

@FremyCompany
Copy link

FremyCompany commented Sep 16, 2022

Rather than stating that making this proposal accessible would be intractable, which might be wrong, I would like instead to provide some resources that explain accessibility requirements for at least two patterns, so they can be contrasted.

Tab Panel:

Radiogroup:

Accordion:

We can discuss here how these things should be achieved?

@FremyCompany
Copy link
Author

FremyCompany commented Sep 16, 2022

My current concerns include at least the following:

  1. that aria-controls and aria-activedescendant are difficult to maintain, because they depend on selectors that do not yet match.
  2. it's not always clear when an element is aria-selected when it's the element which sets the toggle (or whether the element is aria-selected or aria-expanded.
  3. supporting keyboard interactions are very important for these patterns to be accessible, but it seems difficult to do with the current proposal, or at least would still have to be manual, which the current input:checked pattern supports by default due to the nature of the input element.

@bkardell
Copy link

I'd also like to mention that our group in open ui chose not to ship and propose our functional element which did all of this because there was some accessibility concern that perhaps many many of examples found in the wild where we expected this would be deployed might be made worse by using the aria tabs pattern. There's some support for a differently named pattern for this, tho we've not entirely worked out the details which could let us test this openui/open-ui#559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants