[#153876] Fix error when viewing logs for account price groups #2360
Conversation
There was a problem hiding this comment.
I only thought to check this because I happened to check the original PR: if you add or remove an account from a price group, it's still appearing as "User added to price group" for the event.
I'm not sure how easy it will be to make this distinction based on subclass. (I'm worried if we did subclasses, then things like the Account subclasses might cause problems here). We could also try something like passing in some interpolation value, "%{object} added to price group".
I'm not sure what the best solution is, but if it's too difficult, maybe we can change it to "Price group member added" or "Member added to price group".
lib/tasks/cleanup.rake
Outdated
| namespace :log_events do | ||
| desc "update metadata for PriceGroupMembers" | ||
| task metadata: :environment do | ||
| events = LogEvent.where("loggable_type LIKE ?", "PriceGroupMember").where(metadata: nil) |
There was a problem hiding this comment.
Why not just loggable_type: "PriceGroupMember"?
There was a problem hiding this comment.
I started out thinking there were loggable types for the subclasses, and forgot to update. Good catch.
giladshanan
deleted the
153876-fix-error-when-logging-account-price-groups
branch
Release Notes
I think this has actually been broken since #2302.
Run
rake cleanup:log_events:metadataafter merging