[#154126] Refactor welcome email #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Tech task: Refactor new user welcome email
Additional Context
I wanted to do this as part of the updating of the welcome email for UMass. There was a lot of duplication that we don't need between the text version and the html version. This will require a little bit of cleanup in the other schools but it should be straightforward, plus I improved the mailer preview so there's separate previews for internal vs external users.
One last thing I did was renamed
BaseMailertoApplicationMailer, which is the standard name for the mailer superclass for Rails (we originally created these classes before Rails had a standard superclass).