Restructure uploaded file paths and improve instructions for migrating to S3 #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhanggi
commented
Jul 31, 2020
| paperclip: | ||
| storage: filesystem | ||
| url: ":rails_relative_url_root/:attachment/:id_partition/:style/:safe_filename" | ||
| path: ":rails_root/public/:attachment/:id_partition/:style/:safe_filename" | ||
| url: ":rails_relative_url_root/system/:class/:attachment/:id_partition/:style/:safe_filename" |
There was a problem hiding this comment.
I could see an argument that we shouldn't change the default and just make the changes downstream, but I don't like where it's currently stored.
NU is already using the class-prefixed paths on S3.
jhanggi
changed the title
jhanggi
changed the title
giladshanan
reviewed
Sep 18, 2020
| end | ||
| end | ||
| def move_record(new_class, old_record) | ||
| new_record = new_class.find(old_record.id) |
There was a problem hiding this comment.
Is it worth adding a guard clause here to do some logging and skip any invalid old_records? I don't expect there to be any invalid records but since we're saving with validate: false I thought it might make sense to check.
giladshanan
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Tech task: Update the file paths for uploaded files and improve instructions and helper rake takes to aid in migrating to S3.
Breaking changes
The setting for where uploaded files are stored locally has changed from
public/filestopublic/system/:class. You either need to change it back to its previous value or run the rake task as part of your deployment (CHANGELOG.md).In addition, if you are using S3 already, the path for the keys should now just be
paperclip.aws_access_keyandpaperclip.aws_secret_access_key.Notes
We'll need to update the access keys for NU, but their file paths in S3 already have the
:classinterpolation variable, so nothing should need to move for them.