min-vh-50

[LukyVj]

Hey, first of all, thanks for this useful project!

I stupidly tried a .min-vh-50, which doesn't work, where a .min-vh-100 works.

I assumed that it should work, regarding your documentation :

  Base:
     h = height
     min-h = min-height
     min-vh = min-height vertical screen height
     vh = vertical screen height

   Modifiers
     1 = 1st step in height scale
     2 = 2nd step in height scale
     3 = 3rd step in height scale
     4 = 4th step in height scale
     5 = 5th step in height scale

     -25   = literal value 25%
     -50   = literal value 50%
     -75   = literal value 75%
     -100  = literal value 100%

Any idea why it's not performing ? Any ETA about it ?

[LukyVj]

Ok, I found the tachyons/_height.scss file.

Seems like there is only the .min-vh-100 declared.
I took the liberty to add the following :

.min-vh-25 { min-height: 25vh; }
.min-vh-50 { min-height: 50vh; }
.min-vh-75 { min-height: 75vh; }

[LukyVj]

I can even send a PR for it, if you want.

[mrmrs]

Thanks for the consideration but going to pass on adding this to core for now.
I can see how you could be confused by the documentation. It might be worth me splitting those out to a separate module.