Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incoming messages before the first request has been broadcast are lost #1869

Open
mattwr18 opened this issue May 16, 2024 · 0 comments · May be fixed by #2103
Open

[BUG] Incoming messages before the first request has been broadcast are lost #1869

mattwr18 opened this issue May 16, 2024 · 0 comments · May be fixed by #2103

Comments

@mattwr18
Copy link
Contributor

Steps to reproduce

  1. Start with a clean instance
  2. Onboard with a channel, of your choice.
  3. After receiving the onboarding message, respond to it.
  4. See that the message is completely ignored/lost.

Dev Notes

This occurs because of the logic in how we save messages. At the moment, we require there to be an active_request. This is determined by either the latest request the contributor has received, or the latest request that has been broadcast. This causes multiple issues:

  • If there are requests that have been broadcast, but none of them have targeted the contributor, by their tag list, and that contributor responds, it can cause confusion since the message can be assigned to the request that they did not receive.
  • It also means that if there are no requests, the messages are simply not saved at all.

There is a proposal to remove the hard requirement that a message belong to a request, see #1649. While this would solve both issues ☝️ , it requires bigger changes.

It has been proposed that we get past the issue where the message is not saved at all by always ensuring that a new instance has a request created with the content of the welcome message. This way, if a contributor replies before the campaign starts it will be assigned to this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant