Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid files silently succeed #121

Open
emosenkis opened this issue Mar 4, 2018 · 2 comments
Open

Invalid files silently succeed #121

emosenkis opened this issue Mar 4, 2018 · 2 comments

Comments

@emosenkis
Copy link
Contributor

emosenkis commented Mar 4, 2018

Most invalid files silently succeed, producing Text, Start, and Eof events (others are probably possible too).

Examples:

  • The empty file (produces just Eof)
  • foo (produces Text followed by Eof)
  • < (produces Start(BytesStart { buf: [], name_len: 0 }), followed by Eof)
  • <foo> (produces Start, Eof)
@tafia
Copy link
Owner

tafia commented Mar 6, 2018

The empty file (produces just Eof)

I think this is a correct behavior.

For the rest I agree we should add additional checks on event orders.

@Mingun
Copy link
Collaborator

Mingun commented Nov 12, 2023

All things except < are parsed correctly, but it is possible to add a setting to return IllFormed error in those cases. Invalid parsing of < will be fixed in #622.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants