Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.29.0 #607

Closed
8 of 9 tasks
Mingun opened this issue Jun 2, 2023 · 5 comments
Closed
8 of 9 tasks

Release 0.29.0 #607

Mingun opened this issue Jun 2, 2023 · 5 comments

Comments

@Mingun
Copy link
Collaborator

Mingun commented Jun 2, 2023

Checklist (minimal list of actions for cutting release):

  • Merge Implement write_serializable_content on element writer #508?
  • $env:RUSTDOCFLAGS="--cfg docs_rs"; cargo +nightly doc --all-features and check generated documentation for missing / unclear things
  • Update version in Cargo.toml
  • Update Changelog.md with date of release, add new empty Unreleased headings
  • cargo package for final check
  • Push master to my fork, wait while CI pass. Repeat with force pushs if necessary
  • cargo publish
  • Create and push tag v0.29.0 and push master to upstream
  • Create a Release on GitHub (in GitHub UI)
@dralley
Copy link
Collaborator

dralley commented Jun 2, 2023

#508 is a feature, I would expect it would go into 0.29

@Mingun
Copy link
Collaborator Author

Mingun commented Jun 2, 2023

Yes, it is. Actually, semver allows as release either 0.28.3 or 0.29.0. I just thinking, that because we have not breaking changes in current master and in #508, we could do a patch release (the previous 0.28.1 and 0.28.2 I'd made with the same rationale). But if you insist, lets release as 0.29.0

@dralley
Copy link
Collaborator

dralley commented Jun 2, 2023

That's not my understanding of semver, my understanding is that patch releases are for bugfixes rather than functionality. I don't care much though.

@Mingun Mingun changed the title Release 0.28.3 Release 0.29.0 Jun 11, 2023
@Mingun
Copy link
Collaborator Author

Mingun commented Jun 11, 2023

Because I just merged #612 which adds new Error variant, now the target version will be 0.29.0.

@dralley, I plan to make release tomorrow, approximately 15-20 hours later. So if you have time to finish with #609 before that time -- OK. No - well, okay, will be included in the next release

@dralley
Copy link
Collaborator

dralley commented Jun 11, 2023

I won't have time, I have some items at work to deal with first. It's fine to put it in the next release.

@Mingun Mingun closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants