Skip to content

Commit

Permalink
Update RuboCop and fix failing spec
Browse files Browse the repository at this point in the history
A new offense in RuboCop causes an issue when running specs locally.

This commit fixes the behavior by making RuboCop happy with `each_key`

Close sds#464
  • Loading branch information
tagliala committed Dec 19, 2023
1 parent 8a1a117 commit 960e796
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ appraise 'haml6.3' do
end

appraise 'rubocop1.0' do
gem 'rubocop', '~> 1.0.0'
gem 'rubocop', '~> 1.59.0'
end
2 changes: 1 addition & 1 deletion gemfiles/haml5.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 5.0.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml5.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 5.1.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml5.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 5.2.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml6.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 6.0.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml6.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 6.1.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml6.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 6.2.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/haml6.3.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "1.57.2"
gem "rubocop", "1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"
gem "haml", "~> 6.3.0"
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rubocop1.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gem "rspec", "~> 3.8"
gem "rspec-its", "~> 1.0"
gem "appraisal"
gem "overcommit", "0.60.0"
gem "rubocop", "~> 1.0.0"
gem "rubocop", "~> 1.59.0"
gem "simplecov", "~> 0.22.0"
gem "simplecov-lcov", "~> 0.8.0"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -462,22 +462,22 @@ haml_lint_marker_9


!!! Handles an anonymous block with a trailing comment
- list.each do |var, var2| # Some comment
- list.each_key do |var| # Some comment
= foo(:bar => 123)
---
haml_lint_marker_1
list.each do |var, var2| # Some comment
list.each_key do |var| # Some comment
HL.out = foo(:bar => 123) $$2
end
haml_lint_marker_5
---
haml_lint_marker_1
list.each do |_var, _var2| # Some comment
list.each_key do |_var| # Some comment
HL.out = foo(bar: 123)
end
haml_lint_marker_5
---
- list.each do |_var, _var2| # Some comment
- list.each_key do |_var| # Some comment
= foo(bar: 123)


Expand Down

0 comments on commit 960e796

Please sign in to comment.